Skip to content

Commit 0260b13

Browse files
misleading but not dangerous selectAlls
there's only one or zero being selected select should be paired with append for #1239
1 parent f486bcd commit 0260b13

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/heatmap.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ dc.heatMap = function (parent, chartGroup) {
213213

214214
boxes.exit().remove();
215215

216-
var gCols = _chartBody.selectAll('g.cols');
216+
var gCols = _chartBody.select('g.cols');
217217
if (gCols.empty()) {
218218
gCols = _chartBody.append('g').attr('class', 'cols axis');
219219
}
@@ -230,7 +230,7 @@ dc.heatMap = function (parent, chartGroup) {
230230
.attr('x', function (d) { return cols(d) + boxWidth / 2; })
231231
.attr('y', _chart.effectiveHeight());
232232
gColsText.exit().remove();
233-
var gRows = _chartBody.selectAll('g.rows');
233+
var gRows = _chartBody.select('g.rows');
234234
if (gRows.empty()) {
235235
gRows = _chartBody.append('g').attr('class', 'rows axis');
236236
}

0 commit comments

Comments
 (0)