replace last few unnecessary/misleading selectAll

if it's always one item, and it's matched by an append or insert (which
do `select` internally), it should be a `select`
fixes #1239

Author: gordonwoodhull

Changelog.md

@@ -1,6 +1,7 @@
 # 2.0 Series
 ## 2.0.0
 * Bubble chart and heatmap correctly re-select (not selectAll) the sub-components in order to correctly apply new data when redrawn. This affects uses of dc.js where the data is replaced instead of being modified in place. (For example, the case where crossfilter is not used.) By Steffen Dienst and Matt Traynham. ([#1032](https://github.com/dc-js/dc.js/pull/1032), [#1237](https://github.com/dc-js/dc.js/pull/1237))
+* Further changed other unnecessary uses of `selectAll` to `select` - when appending or inserting a single element, one should almost always match that with `select` for updates. ([#1239](https://github.com/dc-js/dc.js/issues/1239))
 * Heatmap column/row filtering is a lot faster ([#649](https://github.com/dc-js/dc.js/issues/649))
 * `colorMixin.colorCalculator` properly documented and deprecated ([#1225](https://github.com/dc-js/dc.js/issues/1225))
 * Development dependencies upgraded, by Matt Traynham ([#1233](https://github.com/dc-js/dc.js/pull/1233))

src/coordinate-grid-mixin.js

@@ -518,15 +518,15 @@ dc.coordinateGridMixin = function (_chart) {
     }
 
     _chart.renderXAxis = function (g) {
-        var axisXG = g.selectAll('g.x');
+        var axisXG = g.select('g.x');
 
         if (axisXG.empty()) {
             axisXG = g.append('g')
                 .attr('class', 'axis x')
                 .attr('transform', 'translate(' + _chart.margins().left + ',' + _chart._xAxisY() + ')');
         }
 
-        var axisXLab = g.selectAll('text.' + X_AXIS_LABEL_CLASS);
+        var axisXLab = g.select('text.' + X_AXIS_LABEL_CLASS);
         if (axisXLab.empty() && _chart.xAxisLabel()) {
             axisXLab = g.append('text')
                 .attr('class', X_AXIS_LABEL_CLASS)
@@ -547,7 +547,7 @@ dc.coordinateGridMixin = function (_chart) {
     };
 
     function renderVerticalGridLines (g) {
-        var gridLineG = g.selectAll('g.' + VERTICAL_CLASS);
+        var gridLineG = g.select('g.' + VERTICAL_CLASS);
 
         if (_renderVerticalGridLine) {
             if (gridLineG.empty()) {
@@ -647,7 +647,7 @@ dc.coordinateGridMixin = function (_chart) {
     _chart.renderYAxisLabel = function (axisClass, text, rotation, labelXPosition) {
         labelXPosition = labelXPosition || _yAxisLabelPadding;
 
-        var axisYLab = _chart.g().selectAll('text.' + Y_AXIS_LABEL_CLASS + '.' + axisClass + '-label');
+        var axisYLab = _chart.g().select('text.' + Y_AXIS_LABEL_CLASS + '.' + axisClass + '-label');
         var labelYPosition = (_chart.margins().top + _chart.yAxisHeight() / 2);
         if (axisYLab.empty() && text) {
             axisYLab = _chart.g().append('text')
@@ -664,7 +664,7 @@ dc.coordinateGridMixin = function (_chart) {
     };
 
     _chart.renderYAxisAt = function (axisClass, axis, position) {
-        var axisYG = _chart.g().selectAll('g.' + axisClass);
+        var axisYG = _chart.g().select('g.' + axisClass);
         if (axisYG.empty()) {
             axisYG = _chart.g().append('g')
                 .attr('class', 'axis ' + axisClass)
@@ -685,7 +685,7 @@ dc.coordinateGridMixin = function (_chart) {
     };
 
     _chart._renderHorizontalGridLinesForAxis = function (g, scale, axis) {
-        var gridLineG = g.selectAll('g.' + HORIZONTAL_CLASS);
+        var gridLineG = g.select('g.' + HORIZONTAL_CLASS);
 
         if (_renderHorizontalGridLine) {
             var ticks = axis.tickValues() ? axis.tickValues() : scale.ticks(axis.ticks()[0]);