Skip to content

Commit 4ee0146

Browse files
committed
Remove brush handles for scatter-plot
1 parent b1f77ba commit 4ee0146

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

spec/scatter-plot-spec.js

+5
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,11 @@ describe('dc.scatterPlot', function () {
234234
chart.redraw();
235235
});
236236

237+
it('should not create brush handles', function () {
238+
var selectAll = chart.select('g.brush').selectAll('path.custom-brush-handle');
239+
expect(selectAll.size()).toBe(0);
240+
});
241+
237242
it('should filter dimensions based on the same data', function () {
238243
jasmine.clock().tick(100);
239244
expect(otherDimension.top(Infinity).length).toBe(3);

src/scatter-plot.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ dc.scatterPlot = function (parent, chartGroup) {
388388
_symbol.size(oldSize);
389389
}
390390

391-
_chart.setHandlePaths = function () {
391+
_chart.createBrushHandlePaths = function () {
392392
// no handle paths for poly-brushes
393393
};
394394

0 commit comments

Comments
 (0)