Skip to content

Commit 74a9dfd

Browse files
committed
Basic eslint setup for ES6 modules
1 parent d635e49 commit 74a9dfd

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

.eslintrc

+5
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,13 @@
11
{
22
"env": {
33
"browser": true,
4+
"es6": true,
45
"node": true
56
},
7+
"parserOptions": {
8+
"ecmaVersion": 6,
9+
"sourceType": "module"
10+
},
611
"globals": {
712
"console": false,
813
"crossfilter": false,

src/data-count.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ export const dataCount = function (parent, chartGroup) {
120120
return this;
121121
};
122122
_chart.dimension = logger.annotate(_chart.crossfilter,
123-
'consider using dataCount.crossfilter instead of dataCount.dimension for clarity');
123+
'consider using dataCount.crossfilter instead of dataCount.dimension for clarity');
124124

125125
_chart.groupAll = function (groupAll) {
126126
if (!arguments.length) {
@@ -130,7 +130,7 @@ export const dataCount = function (parent, chartGroup) {
130130
return this;
131131
};
132132
_chart.group = logger.annotate(_chart.groupAll,
133-
'consider using dataCount.groupAll instead of dataCount.group for clarity');
133+
'consider using dataCount.groupAll instead of dataCount.group for clarity');
134134

135135
return _chart.anchor(parent, chartGroup);
136136
};

src/data-grid.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ export const dataGrid = function (parent, chartGroup) {
148148
* @returns {Function|dc.dataGrid}
149149
*/
150150
_chart.group = logger.annotate(_chart.section,
151-
'consider using dataGrid.section instead of dataGrid.group for clarity');
151+
'consider using dataGrid.section instead of dataGrid.group for clarity');
152152

153153
/**
154154
* Get or set the index of the beginning slice which determines which entries get displayed by the widget.
@@ -247,7 +247,7 @@ export const dataGrid = function (parent, chartGroup) {
247247
* @returns {Function|dc.dataGrid}
248248
*/
249249
_chart.htmlGroup = logger.annotate(_chart.htmlSection,
250-
'consider using dataGrid.htmlSection instead of dataGrid.htmlGroup for clarity');
250+
'consider using dataGrid.htmlSection instead of dataGrid.htmlGroup for clarity');
251251

252252
/**
253253
* Get or set sort-by function. This function works as a value accessor at the item

src/data-table.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ export const dataTable = function (parent, chartGroup) {
247247
* @returns {Function|dc.dataTable}
248248
*/
249249
_chart.group = logger.annotate(_chart.section,
250-
'consider using dataTable.section instead of dataTable.group for clarity');
250+
'consider using dataTable.section instead of dataTable.group for clarity');
251251

252252
/**
253253
* Get or set the table size which determines the number of rows displayed by the widget.
@@ -462,7 +462,7 @@ export const dataTable = function (parent, chartGroup) {
462462
* @returns {Boolean|dc.dataTable}
463463
*/
464464
_chart.showGroups = logger.annotate(_chart.showSections,
465-
'consider using dataTable.showSections instead of dataTable.showGroups for clarity');
465+
'consider using dataTable.showSections instead of dataTable.showGroups for clarity');
466466

467467
return _chart.anchor(parent, chartGroup);
468468
};

0 commit comments

Comments
 (0)