Skip to content

Commit d9be022

Browse files
deselect as well as select when applying filters
here is another thing that should be tested (re: #1019)
1 parent c85c101 commit d9be022

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/select-menu.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,9 @@ dc.selectMenu = function (parent, chartGroup) {
6363
// select the option(s) corresponding to current filter(s)
6464
if (_chart.hasFilter() && _multiple) {
6565
_select.selectAll('option')
66-
.filter(function (d) {
66+
.property('selected', function (d) {
6767
return d && _chart.filters().indexOf(String(_chart.keyAccessor()(d))) >= 0;
68-
})
69-
.property('selected', true);
68+
});
7069
} else if (_chart.hasFilter()) {
7170
_select.property('value', _chart.filter());
7271
} else {

0 commit comments

Comments
 (0)