Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silly filter outro on bar clickaway #1071

Open
gordonwoodhull opened this issue Dec 21, 2015 · 6 comments
Open

silly filter outro on bar clickaway #1071

gordonwoodhull opened this issue Dec 21, 2015 · 6 comments
Labels
Milestone

Comments

@gordonwoodhull
Copy link
Contributor

When you click an empty spot to get rid of the bar chart filter, there's a silly animation.

silly filter outro

It's cute, but no.

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone Dec 21, 2015
@gordonwoodhull
Copy link
Contributor Author

Also on scatterplot.

@Frozenlock
Copy link
Contributor

FWIW, I discovered this animation when grabbing the last minified version from here.

My old version (2.0.0-beta19) didn't have this.

@gordonwoodhull
Copy link
Contributor Author

Thanks @Frozenlock, that's interesting. If anything I would have guessed it was introduced by the chart resizing stuff around beta 15.

Looks like it's transitioning to a zero-width brush instead of an empty brush. I don't think there should be any transition at all.

@Frozenlock
Copy link
Contributor

I don't know if I should open a separate issue for this, but it's another weird animation issue that wasn't present in 2.0.0-beta19 but is in the most recent one:

Bars are now changing width (?!) and don't transition correctly when they need to disappear.

Old
old-dc-js

New
new-dc-js

@gordonwoodhull
Copy link
Contributor Author

Hi @Frozenlock, sorry I missed this. If you're still seeing this and can file a separate issue, that will help a lot. Especially if you can create a demo fiddle.

I don't think I've seen seen this, and I don't see it in any of the standard examples. So it must mean that you've run into some combination of features that we don't test. (Keep in mind that the interaction of features is combinatorial!)

@Frozenlock
Copy link
Contributor

@gordonwoodhull I haven't seen this since I upgraded to a newer version... but I also made a major overhaul in pretty much everything.

I'll pop in here if I ever encounter it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants