layers.size() raises exception

[rlora]

On dc.js the line var last = layers.size() - 1; should be var last = layers.length - 1;?
I debugged the exception and haven't found a reason why size() its been used.

[gordonwoodhull]

Hi @rlora, thanks for the report.

Could you give more detail or a short example which demonstrates the problem you're seeing? And also the exception you're seeing?

I take it you are referring to the bar chart code and some recent code which renders labels. I think .size() is correct as it's fetching the size of the d3 selection:

https://github.com/mbostock/d3/wiki/Selections#size

Note that the loop below is also a d3 selection each not a straight Javascript loop. So it seems to match.

But I don't doubt you're seeing a bug, so let's try to track that down!

[gordonwoodhull]

This code was introduced in #1031

[rlora]

Hi @gordonwoodhull, thanks for your reply.

I'm not sure if you were able to confirm this as a bug. It is happening in BarCharts. I was able to use series and other charts without issues.

The charts I'm using are very simple:

CHARTS.chart21 = dc.barChart("#_cubesExploreChart-2-1", GLOBAL_SCOPE).elasticY(true);
CHARTS.chart21.colors(d3.scale.ordinal().range(Colors.Brewer.Paired[3]));
CHARTS.chart21.x(d3.scale.ordinal().domain(_.pluck(FILTERS.dimensions.weekday.group().all(), "key"))).xUnits(dc.units.ordinal);
CHARTS.chart21.dimension(FILTERS.dimensions.weekday);
CHARTS.chart21.group(FILTERS.dimensions.weekday.group().reduceSum(d => d.value));

dc.renderAll(GLOBAL_SCOPE);

The exception is:

Debugging the exception the layers variable does not contain a size function, although it contains length. Making the change fixes it, and charts work. Although I can't be sure if this has collateral issues.

Thanks!

[gordonwoodhull]

No I wasn't able to confirm it and I can't figure out how a d3 selection object would not have a size function. What version of d3.js are you using?

[rlora]

I'm sorry, my bad. I was using the d3 version packaged by Meteor. Turned out it was outdated and there is an official one. Now using 3.5.8 and it works perfectly. Previously using 3.1.4.

Appreciate your help :)

[gordonwoodhull]

Oh phew, glad that fixed it. Good to know about the interface change and Meteor lagging.