Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 - updaing version from package.json #1542

Closed
kum-deepak opened this issue Aug 11, 2019 · 5 comments
Closed

ES6 - updaing version from package.json #1542

kum-deepak opened this issue Aug 11, 2019 · 5 comments
Labels

Comments

@kum-deepak
Copy link
Collaborator

Ref #1520

Earlier the concat grunt task was placing the version number. Current thinking to factor only version to a file (module) of its own and only pass that through grunt processor.

@gordonwoodhull
Copy link
Contributor

So the module would be generated from package.json instead? Sounds reasonable.

@kum-deepak
Copy link
Collaborator Author

I was thinking of one template file and use grunt to generate the actual version.js

@kum-deepak
Copy link
Collaborator Author

Currently, also, it is generated from package.json.

@kum-deepak
Copy link
Collaborator Author

Please check commit d635e49, close the task if you are happy with the approach.

@gordonwoodhull
Copy link
Contributor

There may be a simpler way to do this (poke around and see how D3 uses rollup for this), but I'm cool with this for now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants