Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with existing add-on libraries #1734

Open
2 tasks
gordonwoodhull opened this issue Aug 2, 2020 · 2 comments
Open
2 tasks

Compatibility with existing add-on libraries #1734

gordonwoodhull opened this issue Aug 2, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@gordonwoodhull
Copy link
Contributor

It is possible that #1729 Concept of Chart Group could break compatibility with external libraries that add new charts to the ecosystem, like dc-addons or our own dc.leaflet.js.

Many of these were never updated to D3v4, so it’s not a big deal. But if they were, we shouldn’t break them now.

It looks like the change is probably backward compatible; this issue is a reminder to self to test and be sure.

There are two cases to consider:

  • charts that use BaseMixin
  • charts that start from scratch
@gordonwoodhull
Copy link
Contributor Author

I don't think dc-addons has been updated in a while.

I maintain dc.leaflet.js, however. For the dc@4 update I adapted the code without moving to ES6, partly as a POC. Would be glad to move to ES6 & Rollup for the next update. The library doesn't have tests, just the demo page, but otherwise it should be straightforward.

@kum-deepak
Copy link
Collaborator

That makes sense, we will start with moving dc.leaflet.js to ES6/typescript and provide assistance for the others as per demand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants