You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is possible that #1729 Concept of Chart Group could break compatibility with external libraries that add new charts to the ecosystem, like dc-addons or our own dc.leaflet.js.
Many of these were never updated to D3v4, so it’s not a big deal. But if they were, we shouldn’t break them now.
It looks like the change is probably backward compatible; this issue is a reminder to self to test and be sure.
There are two cases to consider:
charts that use BaseMixin
charts that start from scratch
The text was updated successfully, but these errors were encountered:
I don't think dc-addons has been updated in a while.
I maintain dc.leaflet.js, however. For the dc@4 update I adapted the code without moving to ES6, partly as a POC. Would be glad to move to ES6 & Rollup for the next update. The library doesn't have tests, just the demo page, but otherwise it should be straightforward.
It is possible that #1729 Concept of Chart Group could break compatibility with external libraries that add new charts to the ecosystem, like dc-addons or our own dc.leaflet.js.
Many of these were never updated to D3v4, so it’s not a big deal. But if they were, we shouldn’t break them now.
It looks like the change is probably backward compatible; this issue is a reminder to self to test and be sure.
There are two cases to consider:
The text was updated successfully, but these errors were encountered: