Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit implemenetation serde::Serialize & Deserialize for types used as keys #60

Open
SebastienGllmt opened this issue Aug 23, 2022 · 1 comment
Labels
bug Something isn't working CDDL feature Feature that is required for proper parsing of CDDL files

Comments

@SebastienGllmt
Copy link
Collaborator

SebastienGllmt commented Aug 23, 2022

I'm not sure if there is a good way to codegen this, but the current codegen logic will not explicitly generate serde::Serialize & serde::de::Deserialize traits for types even if they are used as keys in maps which causes a crash on to_json calls

For example, see dcSpark/cardano-multiplatform-lib#115

@SebastienGllmt
Copy link
Collaborator Author

I think this is somewhat related to #96 since this crash is caused by types that have an unclear serialization format such as addresses needing to be converted to string, etc.

@SebastienGllmt SebastienGllmt added bug Something isn't working CDDL feature Feature that is required for proper parsing of CDDL files labels Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CDDL feature Feature that is required for proper parsing of CDDL files
Projects
None yet
Development

No branches or pull requests

1 participant