Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with new num::Float::epsilon #16

Closed
cuviper opened this issue Oct 3, 2016 · 1 comment
Closed

Conflict with new num::Float::epsilon #16

cuviper opened this issue Oct 3, 2016 · 1 comment

Comments

@cuviper
Copy link

cuviper commented Oct 3, 2016

Just a heads up -- we recently added Float::epsilon in rust-num/num#231, and then a Crater run showed that glm broke due to call ambiguity. See the logs here:
https://tools.taskcluster.net/task-inspector/#ytvixlBAQzCMhtWXQCM3fA/0

The ambiguous call is in your ApproxEq::is_approx_eq, where Self::BaseType::epsilon could now either mean Float::epsilon or your BaseFloat::epsilon. You could change it to a more explicit call to one of these choices. Or since you seem to just be extending Float, you might remove your epsilon. (Float also now has to_degrees and to_radians, if you like.)

@dche
Copy link
Owner

dche commented Oct 4, 2016

Fixed by removing fn epsilon() from BaseFloat.
Thanks for reporting.

@dche dche closed this as completed Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants