You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ambiguous call is in your ApproxEq::is_approx_eq, where Self::BaseType::epsilon could now either mean Float::epsilon or your BaseFloat::epsilon. You could change it to a more explicit call to one of these choices. Or since you seem to just be extending Float, you might remove your epsilon. (Float also now has to_degrees and to_radians, if you like.)
The text was updated successfully, but these errors were encountered:
Just a heads up -- we recently added
Float::epsilon
in rust-num/num#231, and then a Crater run showed that glm broke due to call ambiguity. See the logs here:https://tools.taskcluster.net/task-inspector/#ytvixlBAQzCMhtWXQCM3fA/0
The ambiguous call is in your
ApproxEq::is_approx_eq
, whereSelf::BaseType::epsilon
could now either meanFloat::epsilon
or yourBaseFloat::epsilon
. You could change it to a more explicit call to one of these choices. Or since you seem to just be extendingFloat
, you might remove yourepsilon
. (Float
also now hasto_degrees
andto_radians
, if you like.)The text was updated successfully, but these errors were encountered: