Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCO check fail when commit comes thru GH UI and committer email is set to private #114

Closed
jmertic opened this issue May 30, 2019 · 1 comment

Comments

@jmertic
Copy link

jmertic commented May 30, 2019

See this PR failure...

https://github.com/zowe/zlc/pull/114/checks?check_run_id=137885176

It looks like while the user put in their normal Signed-off-by: in the commit, because they have a GitHub setting on which doesn't pass their real email as the committer ( https://help.github.com/en/articles/about-commit-email-addresses ) we get a mismatch.

Any ideas on what could be done to solve this?

@hiimbex
Copy link
Contributor

hiimbex commented Jul 23, 2019

I think the fix here has to be on the user's end. They can either set their email to public or do as GitHub recommends:

To use your noreply email address for commits you push from the command line, use that email address when you set your commit email address in Git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants