Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduces cost of using DCO #204

Open
alexec opened this issue Jul 14, 2023 · 1 comment
Open

Reduces cost of using DCO #204

alexec opened this issue Jul 14, 2023 · 1 comment

Comments

@alexec
Copy link

alexec commented Jul 14, 2023

Is there anyway to make DCO fundamentally less costly to use?

I’ve seen that engineers spend a lot of time fixing DCO checks, if you factor in the merge conflicts and time lost to context switching, I’d estimate around 30m per pull request. If DCO is used on (say) 5,00,000 pull requests a year and engineers cost around $100/hr, then we’re looking at $250,000,000 spend of fixing DCO each year for the Open Source community. Maybe you think there are fewer pull requests with DCO, so maybe you think fixing it is only $100,000,00 a year? LMK if you have better numbers.

I see even experienced engineers loosing time to fixing DCO checks because there are just too many ways to fail to sign-off a commit. Just forget, use wrong args, merge in master, rebase, use Codespaces, accept a suggestion to a pull request can cause this and you only need one non-signed-off commit to fail a PR.

How can we make it less costly?

  • Remove DCO for all projects.
  • Github provides a button to sign-off commits post-hoc.
  • DCO check only requires one commit signed-off.
  • DCO check provides a button to fix commits.

What else?

@BrentonPoke
Copy link

I think this could be fixed buy having it respect GPG signatures, since I assume your and many other corporate teams are gpg signing commits. That's something I definitely would like and would make me a lot less frustrated when using this thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants