Skip to content

Commit 5e03450

Browse files
authored
feat: use redis:7 instead of redis:6-bullseye, move Redis config, for #17 (#38)
1 parent a0d3afe commit 5e03450

File tree

2 files changed

+17
-14
lines changed

2 files changed

+17
-14
lines changed

docker-compose.redis.yaml

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,20 @@
22
services:
33
redis:
44
container_name: ddev-${DDEV_SITENAME}-redis
5-
image: redis:${REDIS_TAG:-6-bullseye}
5+
image: redis:${REDIS_TAG:-7}
66
# These labels ensure this service is discoverable by ddev.
77
labels:
88
com.ddev.site-name: ${DDEV_SITENAME}
9-
com.ddev.approot: $DDEV_APPROOT
9+
com.ddev.approot: ${DDEV_APPROOT}
10+
restart: "no"
11+
expose:
12+
- 6379
1013
volumes:
11-
- ".:/mnt/ddev_config"
12-
- "ddev-global-cache:/mnt/ddev-global-cache"
13-
- "./redis:/usr/local/etc/redis"
14-
- "redis:/data"
15-
command: ["redis-server", "/usr/local/etc/redis/redis.conf"]
14+
- ".:/mnt/ddev_config"
15+
- "ddev-global-cache:/mnt/ddev-global-cache"
16+
- "./redis:/etc/redis/conf"
17+
- "redis:/data"
18+
command: /etc/redis/conf/redis.conf
1619

1720
volumes:
1821
redis:

tests/test.bats

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,22 +19,22 @@ teardown() {
1919
cd ${TESTDIR}
2020
ddev add-on get ${DIR}
2121
ddev restart
22-
ddev redis-cli INFO | grep "^redis_version:6."
22+
ddev redis-cli INFO | grep "^redis_version:7."
2323
# Check if Redis configuration was setup.
2424
[ -f web/sites/default/settings.ddev.redis.php ]
2525
grep -F 'settings.ddev.redis.php' web/sites/default/settings.php
2626
}
2727

28-
@test "basic installation with Redis tag 7" {
28+
@test "basic installation with Redis tag 6" {
2929
ddev config --project-name=${PROJNAME} --project-type=drupal --docroot=web
3030
ddev start -y
3131
cd ${TESTDIR}
3232
ddev add-on get ${DIR}
33-
ddev dotenv set .ddev/.env.redis --redis-tag=7
33+
ddev dotenv set .ddev/.env.redis --redis-tag=6
3434
# Check if .env file for Redis exists.
3535
[ -f .ddev/.env.redis ]
3636
ddev restart
37-
ddev redis-cli INFO | grep "^redis_version:7."
37+
ddev redis-cli INFO | grep "^redis_version:6."
3838
# Check if Redis configuration was setup.
3939
[ -f web/sites/default/settings.ddev.redis.php ]
4040
grep -F 'settings.ddev.redis.php' web/sites/default/settings.php
@@ -46,7 +46,7 @@ teardown() {
4646
cd ${TESTDIR}
4747
ddev add-on get ${DIR}
4848
ddev restart
49-
ddev redis-cli INFO | grep "^redis_version:6."
49+
ddev redis-cli INFO | grep "^redis_version:7."
5050
# Drupal configuration should not be present
5151
[ ! -f web/sites/default/settings.ddev.redis.php ]
5252
}
@@ -57,7 +57,7 @@ teardown() {
5757
cd ${TESTDIR}
5858
ddev add-on get ${DIR}
5959
ddev restart
60-
ddev redis-cli INFO | grep "^redis_version:6."
60+
ddev redis-cli INFO | grep "^redis_version:7."
6161
# Drupal configuration should not be present
6262
[ ! -f web/sites/default/settings.ddev.redis.php ]
6363
}
@@ -68,7 +68,7 @@ teardown() {
6868
cd ${TESTDIR}
6969
ddev add-on get ${DIR}
7070
ddev restart
71-
ddev redis-cli INFO | grep "^redis_version:6."
71+
ddev redis-cli INFO | grep "^redis_version:7."
7272
# Drupal configuration should not be present
7373
[ ! -f web/sites/default/settings.ddev.redis.php ]
7474
}

0 commit comments

Comments
 (0)