Skip to content

Commit

Permalink
minor fixes for docker
Browse files Browse the repository at this point in the history
  • Loading branch information
ddnexus committed Mar 9, 2021
1 parent 296f060 commit 745e68f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ The pagy docker environment has been designed to be useful for developing:
- The gems are installed in the container `BUNDLE_PATH=/usr/local/bundle` and that dir is `chown`ed to your user, and mounted as the docker volume `pagy_bundle`. You can use the `bundle` command and it will be persisted in the volume, no need to rebuild the image nor pollute your own system.
- Your container user `HOME` is preserved in the `pagy_user_home` volume, so you can even get back to the shell history in future sessions.


## Prerequisites

- recent `docker`
Expand Down Expand Up @@ -60,7 +59,7 @@ Then you cou can run `irb -I lib -r pagy` from the container in order to have `p

Run all the tests by simply running `rake` without arguments.

The `gh-pages` service runs the jekyll server so you can edit the docs files from the local `pagy` dir and have a real-time preview of your changes at `http://localhost:4000`. You don't even need to reload the page in the browser to see the change you do in the `*.md` page file.
The `pagy-jekyll` service runs the jekyll server so you can edit the docs files from the local `pagy` dir and have a real-time preview of your changes at `http://localhost:4000`. You don't even need to reload the page in the browser to see the change you do in the `*.md` page file.

If you are serious about developing, you can integrate this environment with some good IDE that provides docker and ruby integration. I currently use it for all the basic pagy development, fully integrated with [RubyMine](https://www.jetbrains.com/ruby/?from=https%3A%2F%2Fgithub.com%2Fddnexus%2Fpagy).

Expand Down
1 change: 0 additions & 1 deletion docker/pagy.dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
FROM ruby:3


ARG term
ENV TERM="${term:-xterm-256color}"

Expand Down

0 comments on commit 745e68f

Please sign in to comment.