Skip to content

Commit

Permalink
added manifest:check to CI for master and dev and to the default rake…
Browse files Browse the repository at this point in the history
… task
  • Loading branch information
ddnexus committed Apr 21, 2021
1 parent 01f8f1c commit 7927f37
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 8 deletions.
8 changes: 4 additions & 4 deletions .github/ci-gemfiles/ruby-3.0
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
source "https://rubygems.org"

gem 'rake'
gem 'rack'
gem 'ansi'
gem 'i18n'
gem 'minitest'
gem 'ansi'

gem 'oj', require: false # false is for testing with or without it
gem 'rake'
gem 'rack'
gem 'rake-manifest', require: false

gem 'rubocop', '~> 1.11', require: false
gem 'rubocop-minitest', require: false
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/pagy-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
env:
BUNDLE_GEMFILE: .github/ci-gemfiles/ruby-3.0
CODECOV: true
RAKE_MANIFEST: true
fail-fast: false
env: ${{ matrix.env }}

Expand All @@ -40,3 +41,7 @@ jobs:
uses: codecov/codecov-action@v1.3.2
with:
fail_ci_if_error: true

- name: Check whether pagy.manifest is up-to-date in master|dev
if: ${{ env.RAKE_MANIFEST == 'true' && (endsWith(github.ref, '/master') || endsWith(github.ref, '/dev')) }}
run: bundle exec rake manifest:check
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[![Gem Version](https://img.shields.io/gem/v/pagy.svg?label=pagy&colorA=99004d&colorB=cc0066)](https://rubygems.org/gems/pagy)
![ruby](https://img.shields.io/badge/ruby-3.0+-ruby.svg?colorA=99004d&colorB=cc0066)
[![Build Status](https://img.shields.io/travis/ddnexus/pagy/master.svg?colorA=1f7a1f&colorB=2aa22a)](https://travis-ci.org/ddnexus/pagy/branches)
[![Build Status](https://img.shields.io/github/workflow/status/ddnexus/pagy/Pagy%20CI/master)](https://github.com/ddnexus/pagy/actions?query=branch:master)
[![CodeCov](https://img.shields.io/codecov/c/github/ddnexus/pagy.svg?colorA=1f7a1f&colorB=2aa22a)](https://codecov.io/gh/ddnexus/pagy)
![Rubocop Status](https://img.shields.io/badge/rubocop-passing-rubocop.svg?colorA=1f7a1f&colorB=2aa22a)
[![MIT license](https://img.shields.io/badge/license-MIT-mit.svg?colorA=1f7a1f&colorB=2aa22a)](http://opensource.org/licenses/MIT)
Expand Down
2 changes: 1 addition & 1 deletion Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

Rake.add_rakelib 'tasks'

task default: %i[test rubocop coverage_summary]
task default: %i[test rubocop coverage_summary manifest:check]
2 changes: 0 additions & 2 deletions tasks/gem_management.rake
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# frozen_string_literal: true

return if ENV['CI']

# gem build and release tasks, with added checks and patches

require 'bundler/gem_tasks'
Expand Down

0 comments on commit 7927f37

Please sign in to comment.