Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for x64-mingw-ucrt platform #789

Open
sk-ys opened this issue Apr 19, 2023 · 0 comments · May be fixed by #799
Open

Support for x64-mingw-ucrt platform #789

sk-ys opened this issue Apr 19, 2023 · 0 comments · May be fixed by #799

Comments

@sk-ys
Copy link

sk-ys commented Apr 19, 2023

Currently, we're using the /(win|w)32$/ regular expression pattern to identify Windows.
However, this pattern does not correctly identify Windows when using Ruby 3.1 or later.
Since Ruby 3.1, the platform reported by the RubyInstaller for Windows is x64-mingw-ucrt.
Please consider updating the code to support this platform.

foreman/lib/foreman.rb

Lines 13 to 15 in a5f9b78

def self.windows?
defined?(RUBY_PLATFORM) and RUBY_PLATFORM =~ /(win|w)32$/
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant