Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comparison with https://github.com/jangko/nim-noise? #1

Open
timotheecour opened this issue Feb 9, 2021 · 3 comments
Open

Comments

@timotheecour
Copy link

timotheecour commented Feb 9, 2021

refs https://github.com/jangko/nim-noise
refs nim-lang/Nim#16451 (comment)

@de-odex
Copy link
Owner

de-odex commented Feb 9, 2021

I already have hints working, i believe; not sure on windows support as ive never tried it; this is a direct port, i think jangko's is more of a modified port, more akin to a remake or so

@timotheecour
Copy link
Author

timotheecour commented Feb 9, 2021

thanks; I'm asking because of nim-lang/Nim#16451 (comment); araq wants (rightfully so) to remove the linenoise.c, linenoise.h in nim repo to replace it with nim code, but I'm in favor of avoiding duplicate effort if existing libraries have a suitable replacement.

one option would be:

wdyt?

@de-odex
Copy link
Owner

de-odex commented Feb 9, 2021

the license is directly linenoise's license as i don't understand how licenses should work too well, too lawyerese for me to understand i think. i'm not done making this more idiomatic (please tell me if i should or not though). i think it should be okay once i fix up all weird oddities i made a year ago when i was much newer to nim

edit: oddities like me adding a field truebuf to the linenoisestate for some reason that i do not recall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants