Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Use shared download/npm Terraform module #41

Closed
ofhouse opened this issue Jan 24, 2021 · 0 comments · Fixed by #42
Closed

Refactor: Use shared download/npm Terraform module #41

ofhouse opened this issue Jan 24, 2021 · 0 comments · Fixed by #42
Assignees
@ofhouse
Labels
feature/terraform Missing feature from Terraform
Milestone
v0.7.0

Comments

@ofhouse
Copy link
Member

ofhouse commented Jan 24, 2021

For the upcoming next/image feature we reuse the internal npm downloader module in the image optimizer module.
It is now released as an stand-alone module here: https://registry.terraform.io/modules/dealmore/download/npm

References to the internal module should replaced with the shared module.
@ofhouse ofhouse added the feature/terraform Missing feature from Terraform label Jan 24, 2021
@ofhouse ofhouse self-assigned this Jan 24, 2021
ofhouse added a commit that referenced this issue Jan 24, 2021
@ofhouse
Refactor: Use shared npm download module (#41)
33cef41
@ofhouse ofhouse mentioned this issue Jan 24, 2021
Merged
ofhouse added a commit that referenced this issue Jan 24, 2021
@ofhouse
Merge pull request #42 from dealmore/refactor/npm-downloader
a51e88a 
Refactor: Use shared npm download module (#41)
@ofhouse ofhouse added this to the v0.7.0 milestone Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ofhouse ofhouse

Labels
feature/terraform Missing feature from Terraform
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Refactor: Use shared npm download module (#41) milliHQ/terraform-aws-next-js
1 participant
@ofhouse