Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packaging for components #43

Closed
3 tasks done
ofhouse opened this issue Jan 25, 2021 · 0 comments
Closed
3 tasks done

Update packaging for components #43

ofhouse opened this issue Jan 25, 2021 · 0 comments
Assignees
@ofhouse
Labels
enhancement
Milestone
v0.7.0

Comments

@ofhouse
Copy link
Member

ofhouse commented Jan 25, 2021 •
edited
Loading

We currently rely on an internal tool called @dealmore/funny for building the components (proxy, static-deployment) that are deployed as lambdas.
Since we currently only use the packaging part of the tool, we should replace it with ncc-zip.

ToDo

  • Replace all occurrences of @dealmore/funny with ncc-zip
  • Republish all affected components
  • Release new Terraform module version with the updated components
@ofhouse ofhouse self-assigned this Jan 25, 2021
ofhouse added a commit that referenced this issue Jan 30, 2021
@ofhouse
Use ncc for component bundling (#43)
a4b936f
@ofhouse ofhouse mentioned this issue Jan 30, 2021
Merged
ofhouse added a commit that referenced this issue Jan 30, 2021
@ofhouse
Use ncc for component bundling (#43)
a1ce1de
ofhouse added a commit that referenced this issue Jan 30, 2021
@ofhouse
Merge pull request #45 from dealmore/refactor/ncc-cli
7b1b4c3 
Use ncc for component bundling (#43)
@ofhouse ofhouse closed this as completed Feb 2, 2021
@ofhouse ofhouse added this to the v0.7.0 milestone Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ofhouse ofhouse

Labels
enhancement
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
1 participant
@ofhouse