feat: Expose proxy hosted zone id #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows more complicated aliasing that currently possible with just the name exposed. Having both the domain name and hosted zone id will allow us to punch it into the alias on our own external `aws_route53_record` for a more custom approach to custom domains. The main reason for this is that we currently have different providers in different regions for our infrastructure and managing dns/route53, which as the providers differ means we can't use the currently available approach to custom domains.
ofhouse
approved these changes
Jan 13, 2021
|
Now released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the project, and your time spent on it!
These small changes aim to allow more complicated aliasing than currently possible with just the name exposed. Having both the domain name and hosted zone id will allow us to punch it into the alias on our own controlled
aws_route53_recordresource directly for a more custom approach to custom domains - as it needs both these values.The main reason for this is that we currently have different providers in different regions for our infrastructure and managing dns/route53, which as the providers differ means we can't use the currently available approach to custom domains.