Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the src attribute after event handlers are attached #10

Open
timocouckuyt opened this issue Nov 22, 2018 · 0 comments
Open

Set the src attribute after event handlers are attached #10

timocouckuyt opened this issue Nov 22, 2018 · 0 comments

Comments

@timocouckuyt
Copy link

Hi @deanhume,

Great work on this! I've got a small remark, tho. Please, correct me if I'm wrong.

I think you might want to attach the onload and onerror event handlers after you set the src attribute of the image in fetchImage to also get the onload event fired for browser cached images.

Let me know what you're opinion is on this.

Cheers!

// T
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timocouckuyt