Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with notify.notify in release version #187

Open
deafmute1 opened this issue May 23, 2024 · 2 comments
Open

Issues with notify.notify in release version #187

deafmute1 opened this issue May 23, 2024 · 2 comments

Comments

@deafmute1
Copy link

deafmute1 commented May 23, 2024

Two issues that I encountered with notify due to undocumented/wrong documented behavior.

  1. Version downloaded via pip has different signature vs main/docs.
    Pip version has signature notify(title, subtitle, message, sound), and raises ValueError if message == '', but main/docs have signature notify(title, subtitle, sound) with value error if title == subtitle == ''. I kept calling this function exactly as docs describe but getting ValueError...

  2. notify.notify requires you have a file at workflowdir/icon.png, otherwise you get somewhat cryptic error. It doesn't describe the need for an icon anywhere in this project's docs.

@deafmute1 deafmute1 changed the title Undocumented behaviour with notify.notify in release version Issues with notify.notify in release version May 23, 2024
@deafmute1
Copy link
Author

Now that I'm not getting Exceptions, it just fails silently, no notification produced.

Dig down a bit, and directly called the generate applet (cachedir/alfred/package/Notificator.app..../applet) with various differing amounts of strings, regardless of what I input it silently fails (M1 Mac on 14.5 Sonoma).

@deafmute1
Copy link
Author

Okay reading around the issues more and I see this repo is py2.7 and the version on pypi is a fork for py3 support. Would be good to include disclaimer on repo/archive the repo if no more work will occur here! its still very high on google and linked to from everywhere!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant