Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional mouse button support #51

Closed
rmb938 opened this issue May 28, 2018 · 11 comments · Fixed by #391
Closed

Additional mouse button support #51

rmb938 opened this issue May 28, 2018 · 11 comments · Fixed by #391
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rmb938
Copy link

rmb938 commented May 28, 2018

Operating Systems

Server: Fedora 28

Client: Windows 10 Build 1803

Barrier Version

2.1.0

Steps to reproduce bug

  1. Use a mouse that has additional buttons (i.e forward and back buttons)
  2. Try and use those buttons while in the client

Other info

It would be nice if at least the forward and back buttons would work.

@yupi2
Copy link

yupi2 commented May 28, 2018

I got forward&back buttons working along with horizontal scroll some time ago. Works on X11 & Win32 but I never tested on OSX.
main patch:

later patch to suppress warning:

If/when someone applies the patch remember to include my author information for git.

@walker0643
Copy link
Member

Can someone make a PR for this please?

@walker0643 walker0643 added enhancement New feature or request help wanted Extra attention is needed labels Jun 30, 2018
@walker0643
Copy link
Member

Inactive for over 2 months. Closing (but would still like to have the PR!)

@aaronsb
Copy link

aaronsb commented Dec 13, 2018

Inactive for over 2 months. Closing (but would still like to have the PR!)

What's the most effective way to get this patch integrated? I'd really like to use my back and forward buttons without maintaining an entire copy of this. 👍

@vorph1
Copy link

vorph1 commented Jan 23, 2019

Hi, here's a patch with yupi2's changes modified to apply correctly to barrier.

vorph1@5111f40

Back/forward buttons and horizontal scroll work but there's some instability. I'm not sure if that's from the patch or the master branch is unstable itself as I only applied to head and not any stable releases.
Tested only linux server and win10 client so far.

@vorph1
Copy link

vorph1 commented Jan 25, 2019

I've now confirmed that the instability is not present with the patch applied to 2.1.2.
I might find time to set up a macos instance to test but no promises there.

Would you consider merging the patch as is or do you need any changes? Also I'm not sure where would be the best place to mention it's yupi2's contribution so any feedback welcome there.

@AdrianKoshka
Copy link

Would just need to create a PR. I could do it and then we could review the code.

@aaronsb
Copy link

aaronsb commented May 31, 2019

Would just need to create a PR. I could do it and then we could review the code.

Has a PR been created yet?

@AdrianKoshka
Copy link

Yes, #242

@RotBolt
Copy link

RotBolt commented Sep 17, 2021

Hello, I am still facing the same issue. I have mouse with additional buttons and horizontal scroller and its not working
I was trying barrier on macOS and Ubuntu

@ajstun
Copy link

ajstun commented Sep 2, 2022

Hello, I am still facing the same issue. I have mouse with additional buttons and horizontal scroller and its not working I was trying barrier on macOS and Ubuntu

Try this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants