Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Use npm cache add instead of npm install in fetch #165

Open
Kixunil opened this issue Aug 6, 2021 · 0 comments
Open

Feature: Use npm cache add instead of npm install in fetch #165

Kixunil opened this issue Aug 6, 2021 · 0 comments
Labels
enhancement New feature or request robustness Makes the system less liklely to breaak

Comments

@Kixunil
Copy link
Collaborator

Kixunil commented Aug 6, 2021

Is your feature request related to a problem? Please describe.
Running npm install before building has several disadvantages:

  • Takes a long time which makes build-dep step more annoying
  • Makes it impossible to properly isolate builds
  • Can not be configured per-package
  • May be causing rebuild issues
  • It's an ugly exception in the architecture

Describe the solution you'd like
What we wanted to achieve - downloading dependencies - should be achievable using npm cache add. We can build it later with npm install

Describe alternatives you've considered

  • We could get rid of vendoring completely but that would mean perfect build isolation is impossible
  • We could hand-vendor the dependencies (e.g. as Debian packages) - very time-consuming even though also very clean.

Additional context
Required if #82 is revisited

@Kixunil Kixunil added enhancement New feature or request robustness Makes the system less liklely to breaak labels Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request robustness Makes the system less liklely to breaak
Projects
None yet
Development

No branches or pull requests

1 participant