Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dotnet builds #166

Open
1 of 5 tasks
Kixunil opened this issue Aug 6, 2021 · 1 comment
Open
1 of 5 tasks

Refactor dotnet builds #166

Kixunil opened this issue Aug 6, 2021 · 1 comment
Labels
code quality Makes code easier to understand and less likely to lead to problems enhancement New feature or request

Comments

@Kixunil
Copy link
Collaborator

Kixunil commented Aug 6, 2021 •
edited
Loading

Dotnet builds were written mostly blindly and suffer some issues such as needlessly building everything.
To fix it:

  • Build only required binaries
  • Build directly into destination directory instead of copying (is this considered "nice", though?)
  • If we ever need more than one package make shared packages using dotnet store and manifests (how to find intersect?)
  • Name /usr/lib/$package same as package - no pascal case
  • Move wwwroot to /usr/share and link it if it's a shared package (is there a better way?)
@Kixunil
Copy link
Collaborator Author

Kixunil commented Aug 6, 2021

LOL, forgot we already have the most important part :D
But I think it should be changed to array: for each csproj specify separate output.

@Kixunil Kixunil added code quality Makes code easier to understand and less likely to lead to problems enhancement New feature or request labels Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Makes code easier to understand and less likely to lead to problems enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kixunil