Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subset with exact array order #65

Open
bladeSk opened this issue Aug 1, 2017 · 1 comment
Open

Subset with exact array order #65

bladeSk opened this issue Aug 1, 2017 · 1 comment

Comments

@bladeSk
Copy link

bladeSk commented Aug 1, 2017

As the title says. Have you considered adding this functionality? I found myself needing to use it a lot when testing MongoDB outputs and any other structured data, really.

[1, 2, 3].should.containSubsetInOrder([1, 2, 3]];
[1, 2, 3].should.not.containSubsetInOrder([3, 2, 1]];

Here's a fork of your library that implements this: chai-subset-in-order. But why use 2 libraries, when the original one could handle this easily? I could do a PR. Would you consider merging this in?

Related issue #46

@eagleeye
Copy link
Contributor

eagleeye commented Aug 2, 2017

@bladeSk yeap, I'll merge it. Don't forget to write some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants