Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Error #5

Open
frodeaux opened this issue Jun 14, 2012 · 1 comment
Open

Comment Error #5

frodeaux opened this issue Jun 14, 2012 · 1 comment

Comments

@frodeaux
Copy link

This is nothing major, just something I caught while looking into this framework. BTW the framework seems very useful and I plan to study it a bit more. The example is a huge help, probably better than documentation would ever be, although a bit more documentation would be nice !

Anyway, the commenting error in Resources/mvc/controllers/example.js For the this.tabgroup function the comment points to a file that doesn't exist. Like I said this is not really a big deal except when trying to learn the framework by following the example.

Another question I have: You seem to create the tab group in the example controller, since technically the tabs and tab group are part of a View, shouldn't the definition be in a view file? This is just an observation, I have much more to study on this framework, I am just wondering if you could clear this up for me !

@frodeaux frodeaux reopened this Jun 14, 2012
@flakerimi
Copy link
Contributor

As for first question I removed that part of comment, since it is more about your second question. If you action is small you dont have to create new file/view you can put code directly to action, tabgroup illustrate that, dashboard and multidashboard works as it should. This is just an example of using controllers.

Just update and it will be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants