Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Slate plugins to drop data arg #855

Closed
erquhart opened this issue Nov 30, 2017 · 0 comments
Closed

Update Slate plugins to drop data arg #855

erquhart opened this issue Nov 30, 2017 · 0 comments
Labels
good first issue kind: bug
Milestone
1.0.0

Comments

@erquhart
Copy link
Contributor

erquhart commented Nov 30, 2017 •
edited
Loading

As mentioned in #854, slate-react stopped providing the data object to event handlers in 0.6.0 - our plugins currently use it to determine which key was pressed. Need to migrate to use the native event.key instead.

Also, this is probably breaking stuff and may or may not allow us to close other issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue kind: bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@erquhart