Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent empty pages #2288

Closed
xraystyle1980 opened this issue Aug 20, 2024 · 6 comments · Fixed by #2389
Closed

Consistent empty pages #2288

xraystyle1980 opened this issue Aug 20, 2024 · 6 comments · Fixed by #2389
Assignees
Labels
enhancement New feature or request

Comments

@xraystyle1980
Copy link

xraystyle1980 commented Aug 20, 2024

Please update all "empty" pages site wide and across all viewports. Empty pages are any pages in the app a user can navigate to but no data has been added that would be visible in the UI.
Notable changes:

  • All empty pages should use the body-base text style at color neutral-6
  • None of the empty cards should have a clickable call to action in the message
  • All of the empty cards should have the new raised effect
  • Padding on desktop empty cards should be 24px
  • Padding on mobile empty cards should be 16px

image
image
image
image
image

@xraystyle1980 xraystyle1980 added the enhancement New feature or request label Aug 21, 2024
@mudrila
Copy link
Contributor

mudrila commented Aug 22, 2024

I know @tomstuart123 might have different take on removing action button from "Empty box" - and I kinda agree for cases like Proposals, Proposal templates, Roles (and maybe Activity on Dashboard?)

@tomstuart123
Copy link

@mudrila could you elaborate. I actually have no problem with 'empty box having no CTA'.

Unless I misunderstand, we don't follow this pattern in-app currently. Do we?

@mudrila
Copy link
Contributor

mudrila commented Sep 2, 2024

@mudrila could you elaborate. I actually have no problem with 'empty box having no CTA'.

Unless I misunderstand, we don't follow this pattern in-app currently. Do we?

We do have a quick action for creating proposal and creating template, as far as I know
I might be wrong but I feel like I heard from you that you find it pretty useful and wanted to have it somewhere else 😅

@tomstuart123
Copy link

ah I didn't have my wallet connected when I had zero proposals. Once i connected the wallet, I saw the relevant prompt below
Screenshot 2024-09-02 at 15 39 58

@xraystyle1980 , no issue from me. I agree that pointing them to the above (as we do in roles) is much cleaner.

@tomstuart123
Copy link

tomstuart123 commented Sep 2, 2024

@mudrila any reason we can't move this into 'ready'? Or do you have any issue?

@mudrila
Copy link
Contributor

mudrila commented Sep 2, 2024

We can move it to "Ready" - I guess it wasn't there cause there was no triaging, but we should be good

@mudrila mudrila self-assigned this Oct 3, 2024
mudrila added a commit that referenced this issue Oct 4, 2024
…y-pages

Consistent empty messages & Mobile Top Nav adjustments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants