Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange behavior on date picker component. #2315

Closed
nicolaus-sherrill opened this issue Aug 27, 2024 · 1 comment · Fixed by #2374
Closed

Strange behavior on date picker component. #2315

nicolaus-sherrill opened this issue Aug 27, 2024 · 1 comment · Fixed by #2374
Assignees

Comments

@nicolaus-sherrill
Copy link

nicolaus-sherrill commented Aug 27, 2024

Strange behavior on this date picker component. The start and end date inputs do not share the same component, rather they use two different date pickers, so I can select and override two different date ranges.

Additionally, the input field does not respond when I select a date and remains blank.

Lastly, I know we designed the date input fields in the date picker itself to be manually typed, but they aren't currently interactive and due to the positioning of the component the two input fields look very redundant. I think we should just remove those date fields from the date picker component.

recording

Browser metadata
Path:      /roles/edit/details?dao=sep:0xe20221A8939F9373C091262CBEF9493aca196acD&hatId=0xaac26be5e48b1859b982553e0ed9da801827d128cddd7f96627e8cdcb60eba2f
Browser:   Chrome 127.0.0.0 on Mac OS 10.15.7
Viewport:  1425 x 904 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

Originally posted by @nicolaus-sherrill in #2309 (comment)

@decentdao decentdao deleted a comment Aug 27, 2024
@decentdao decentdao deleted a comment from caineblood Aug 27, 2024
@adamgall
Copy link
Member

adamgall commented Sep 18, 2024

Two Phase Approach:

  1. Start by just creating two single date pickers (for right now, for this issue)
    1. Select Start Date
    2. Select End Date (can't be before Start Date)
    3. No range highlighting
    4. Just two simple date pickers
  2. Down the road come back to the UX and figure out a way to consolidate into a single Date Picker which includes the range selection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants