fix: extra button behaviour in navbar (#566)

decentraland · Nov 21, 2024 · 7c48103 · 7c48103
1 parent 80dff04
commit 7c48103
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/components/Navbar/MainMenu/MainMenu.tsx b/src/components/Navbar/MainMenu/MainMenu.tsx
@@ -75,6 +75,7 @@ export const MainMenu = (props: MainMenuProps) => {
           mainUrl={extraButton.link}
           textColor={extraButton.textColor}
           backgroundColor={extraButton.backgroundColor}
+          isExtraButton
         />
       ) : null}
     </div>

diff --git a/src/components/Navbar/MenuItem/MenuItem.tsx b/src/components/Navbar/MenuItem/MenuItem.tsx
@@ -16,7 +16,8 @@ export const MenuItem = (props: MenuItemProps) => {
     isMobile,
     mainUrl,
     textColor,
-    backgroundColor
+    backgroundColor,
+    isExtraButton
   } = props
 
   const mainRedirect = useCallback(() => {
@@ -27,7 +28,9 @@ export const MenuItem = (props: MenuItemProps) => {
     <Menu.Item
       active={activePage === section}
       onClick={(e: React.MouseEvent) => {
-        isMobile ? onToggleShowSubMenu(e, true, section) : mainRedirect()
+        isMobile && !isExtraButton
+          ? onToggleShowSubMenu(e, true, section)
+          : mainRedirect()
       }}
       onMouseEnter={(e: React.MouseEvent) =>
         !isMobile && onToggleShowSubMenu(e, true, section)

diff --git a/src/components/Navbar/MenuItem/MenuItem.types.ts b/src/components/Navbar/MenuItem/MenuItem.types.ts
@@ -11,6 +11,7 @@ export type MenuItemProps = {
   ) => void
   mainUrl?: string
   isMobile?: boolean
+  isExtraButton?: boolean
   textColor?: string
   backgroundColor?: string
 }