Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixture Proof010.json open to Interpretation #315

Open
roblesjoel opened this issue Feb 16, 2024 · 0 comments
Open

Fixture Proof010.json open to Interpretation #315

roblesjoel opened this issue Feb 16, 2024 · 0 comments

Comments

@roblesjoel
Copy link

In the fixture proof010.json, there are two identical disclosed indexes.
For me that also means that in the disclosed messages vector, the same message is present twice.
There is no check for that.
The only check is if the length of the disclosed messages is the same as the length of the disclosed indexes.

Other implementations (see Greg Bernstein's JS implementation) solve this issue by filtering the fixture messages, so that the messages only appears once in the vector.
In that case the lengths of the disclosed messages and indexes would mismatch.

There should be a check if the disclosed indexes are in order, and maybe a check if there are duplicate entries in the vectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant