Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Review of Differences #79

Closed
brentzundel opened this issue Mar 7, 2022 · 13 comments
Closed

Security Review of Differences #79

brentzundel opened this issue Mar 7, 2022 · 13 comments
Labels
core Associated to the core spec

Comments

@brentzundel
Copy link
Member

The work on the specification is progressing well, but there seem to be a number of changes being considered that will cause this specification to deviate from the published and peer-reviewed academic papers.

While there may be more, I am concerned in particular about:
#19
#37
#70
#78

If these changes, or any others, are made which result in a deviation from the security proofs of the source material, then new security proofs need to be written before this spec is submitted as a draft to IETF.

@tplooker
Copy link
Member

tplooker commented Mar 7, 2022

Thanks Brent I think we need to be careful to seperate where there are true deviations from academic literature VS ones where the literature was just not aiming to define anything at that layer, for example #78 is not a deviation from academic literature its just merely a mechanism to ensure cipher suite domain separation

@andrewwhitehead
Copy link
Contributor

I think that deterministic signatures also have to be evaluated in the context of the unforgeability proof.

@tplooker
Copy link
Member

tplooker commented Mar 7, 2022

For example #62 from @mikelodder7 should be included.

@mikelodder7
Copy link
Contributor

mikelodder7 commented Mar 7, 2022

62 is computing the same thing as before it’s just removing the same check from being performed twice. It doesn’t need a security proof

@BasileiosKal
Copy link
Contributor

I do also agree. From the above IMO #19 has the biggest need for a security analyses. The reason I feel confident to keep using the proposed change is that it doesn't really change the security proofs of the original academic material (both the unforgeability and the zero knowledge proof of knowledge work the same).

Also note that the construction on section 5 of the original paper considers as the issuers public key only w and all other generators are created for all parties from a "common reference string functionality" and not from the issuer (similarly to what that issue proposes).

For some of the other issues, a security proof was written and is currently discussed for #70 although it does need reviews, #37 is essentially just a commitment the same with the ones considered in the original paper and as @tplooker noted, i don't see what security proof #78 will need.

@BasileiosKal
Copy link
Contributor

62 is computing the same thing as before it’s just removing the same check from being performed twice

I think @tplooker meant the changes to the equations going in the SPK from the ones in the paper, not the duplicate checks part (which i do like).

@mikelodder7
Copy link
Contributor

AFAIK there are no changes to the SPK that I made and should already match the original paper

@BasileiosKal
Copy link
Contributor

BasileiosKal commented Mar 7, 2022

AFAIK there are no changes to the SPK that I made and should already match the original paper

I think the first equation is different as i mentioned here. This is maybe better discussed elsewhere, (like #69 or maybe in a call?), but not saying that the math are not balanced, just that right now the first equation of the SPK is different (i think its Abar - D = - A' * e - H0 *r2, which is not simply the negation of what the paper uses). Whenever the change was introduced, it may need a security analyses (although it may be easier to update to use the same equations as in the paper).

@tplooker tplooker added the core Associated to the core spec label Apr 21, 2022
@tplooker
Copy link
Member

tplooker commented Dec 5, 2022

We are awaiting review of some new academic work that has be produced that re proves formal security for the scheme in a setting that is very close to what this draft documents. Furthermore we expect wider security review at the CFRG during the subsequent standardisation process. For now we will keep this issue open until progress is made on those two paths.

@BasileiosKal
Copy link
Contributor

Discussed on WG call on 20th of Mar. Will revisit after we review and potentially use the updates from the latest academic works.

@tplooker
Copy link
Member

tplooker commented May 8, 2023

With the publication of the new academic paper in EURO crypt and the pending updates to our draft to formally align it, once these have been applied, the intention is to close this issue.

@BasileiosKal
Copy link
Contributor

Discussed on the WG call on the 17th of July. Will review and discuss closing this next week.

@BasileiosKal
Copy link
Contributor

Discussed on the WG call on the 28th of Aug. Draft using latest academic work. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Associated to the core spec
Projects
None yet
Development

No branches or pull requests

5 participants