Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Ed25519VerificationKey publicKeyMultibase conversion #1139

Closed
DaevMithran opened this issue Feb 27, 2023 · 0 comments · Fixed by #1156
Closed

Incorrect Ed25519VerificationKey publicKeyMultibase conversion #1139

DaevMithran opened this issue Feb 27, 2023 · 0 comments · Fixed by #1156
Labels
bug Something isn't working

Comments

@DaevMithran
Copy link

DaevMithran commented Feb 27, 2023

Bug severity: 3

Describe the bug
Conversion of publicKeyMultibase to publicKeyHex in Ed25519VerificationKey2020 doesn't remove the Multibase header present in the publicKeyMultibase according to the spec

To Reproduce
Steps to reproduce the behaviour:

  1. Issue a JsonLD credential using an assertion method of type Ed25519VerificationKey2020 in a Issuer DID. This will result in an error.

Observed behaviour
This is the below observed behviour, as the prefix is not removed the publicKeyHex is different from the local wallet keys

throw Error(`key_not_found: No suitable signing key found for ${identifier.did}`);
                  ^
Error: key_not_found: No suitable signing key found for did:cheqd:testnet:570996eb-393a-4659-8f88-71cb53488eb4
    at CredentialIssuerLD.findSigningKeyWithId 

Expected behaviour
The credential should be issued to the holder

  1. Verify JWT credential issued by Ed25519VerificationKey2020 method Issuer DID.

Observed behaviour
The credential was not verified successfully

Expected behaviour
The credential was verified successfully

@DaevMithran DaevMithran added the bug Something isn't working label Feb 27, 2023
@DaevMithran DaevMithran changed the title Incorrect publicKeyMultibase conversion Incorrect Ed25519VerificationKey publicKeyMultibase conversion Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant