feat(did-manager): matching DIDs by alias should not depend on the provider #1218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this PR fixing
fixes #1215
What is being changed
DIDManager
no longer relies on thealias
+provider
pair when storing or filtering identifiers.It is now impossible to use the same alias on 2 identifiers from different providers.
didManagerGetOrCreate
still accepts aprovider
param in case it needs to create a new DID, but if it encounters an identifier with an existingalias
but using a differentprovider
it will throw an error.AbstractDIDStore.getDID()
no longer uses aprovider
parameter.@veramo/data-store
and@veramo/data-store-json
packages have been adapted to match the expected behavior of the DID managerQuality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.Details
BREAKING CHANGE: The behavior of
DIDManager
has changed when working withalias
. It is mostly ignoringprovider
unless it is used to create new identifiers.AbstractDIDStore
APIs have been adapted and implementations have changed.Merging this PR into
main
will trigger a new major release