fix(utils): bump did-jwt to 7.4.1 and reuse key conversion code from it #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickreynolds
approved these changes
Sep 27, 2023
mirceanis
force-pushed
the
did-jwt-upgrade
branch
from
d7278cd to
49e7324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this PR fixing
fixes #1248
closes #1245
What is being changed
v7.4.1 of did-jwt exports the key conversion methods (and other conversion functions)
This PR uses this latest did-jwt version and replaces the code implemented by veramo with the imported methods, where it made sense.
With these imported methods it was also possible to remove some deprecated dependencies from
@veramo/did-provider-keyand@veramo/did-provider-peer, closing #1245Quality
Check all that apply:
pnpm i,pnpm build,pnpm test,pnpm test:browserlocally.Details
The actual fix for #1248 is in did-jwt, but it is a good opportunity to deduplicate some code.