Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework tree insert to remove unneeded parent update #14

Open
declanvk opened this issue Oct 4, 2022 · 0 comments
Open

Rework tree insert to remove unneeded parent update #14

declanvk opened this issue Oct 4, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@declanvk
Copy link
Owner

declanvk commented Oct 4, 2022

Current in the insert_unchecked function we will unconditionally update the parent node if it was found during search: https://github.com/declanvk/blart/blob/main/src/nodes/operations/insert.rs#L372-L373

Based on experience writing the delete_unchecked function, we can choose to conditionally write to update the parent node only when the insert function creates a new inner node.

@declanvk declanvk added the bug Something isn't working label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant