Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync attempts after shutdown signal #1740

Closed
xaur opened this issue May 14, 2019 · 2 comments
Closed

Sync attempts after shutdown signal #1740

xaur opened this issue May 14, 2019 · 2 comments

Comments

@xaur
Copy link

xaur commented May 14, 2019

Not sure if it's a bug, but just in case.

[INF] BMGR: Processed <count> blocks (...)
[INF] BMGR: New valid peer <peer1> (outbound) (/dcrwire:0.3.0/dcrd:1.4.0/)
[INF] BMGR: New valid peer <peer2> (outbound) (/dcrwire:0.3.0/dcrd:1.4.0/)
[INF] BMGR: New valid peer <peer3> (outbound) (/dcrwire:0.3.0/dcrd:1.4.0/)
^C
[INF] DCRD: Received signal (interrupt).  Shutting down...
[INF] DCRD: Gracefully shutting down the server...
[WRN] SRVR: Server shutting down
[WRN] RPCS: RPC server shutting down
[INF] RPCS: RPC server shutdown complete
[INF] BMGR: Lost peer <peer4> (outbound)
[INF] BMGR: Syncing to block height <height> from peer <peer5>
[INF] BMGR: Lost peer <peer5> (outbound)
[INF] BMGR: Syncing to block height <height> from peer <peer6>
[INF] BMGR: Lost peer <peer6> (outbound)
[INF] BMGR: Syncing to block height <height> from peer <peer1>
[INF] BMGR: Lost peer <peer1> (outbound)
[INF] BMGR: Syncing to block height <height> from peer <peer2>
[INF] BMGR: Block manager shutting down
[INF] BMGR: Lost peer <peer2> (outbound)
[INF] BMGR: Syncing to block height <height> from peer <peer3>
[INF] AMGR: Address manager shutting down
[INF] SRVR: Server shutdown complete
[INF] DCRD: Gracefully shutting down the database...
[INF] DCRD: Shutdown complete

edit: v1.4.0 release

@davecgh
Copy link
Member

davecgh commented Jun 6, 2019

Thanks for reporting.

I'll leave this open as it can be addressed when we eventually get around to reworking the sync logic, but this really isn't an issue. The block manager doesn't shutdown until after all of the peers are shutdown (which necessarily disconnects them), so as the current sync peer is shutdown/disconnected, it chooses another one and logs the selection. Any attempts to send any messages to peers are ignored during shutdown, so it's really just a case of the log message being a bit misleading.

@davecgh
Copy link
Member

davecgh commented Jun 22, 2022

This was resolved by #2555.

@davecgh davecgh closed this as completed Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants