Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discussion: client order archiving #3011

Open
buck54321 opened this issue Oct 6, 2024 · 3 comments
Open

discussion: client order archiving #3011

buck54321 opened this issue Oct 6, 2024 · 3 comments

Comments

@buck54321
Copy link
Member

In working through #2975, it became clear that we needed solutions with more nuance. We'll use this issue to discuss a proper solution for order archiving.

  • We'll want to give users some control over how orders are archived. These controls will need to be available through the UI.
  • We should keep in mind that future functionality might benefit from having a full order history. An example might be a chart that graphs trade history. In this case, we won't want to delete archived orders outright, but we can almost certainly reduce their footprint by e.g. deleting signature data from proofs, or creating a parallel archive that encodes only the minimum pieces of relevant information.
  • Users may want to limit archived orders to a certain number of orders, or only until a certain age, or even limit the amount of disk space allocated to the archive
  • Users may want to archive orders only in combination with a backup process where they can move the records to a separate file.
@martonp
Copy link
Contributor

martonp commented Oct 9, 2024

Users may want to limit archived orders to a certain number of orders, or only until a certain age, or even limit the amount of disk space allocated to the archive.

I think the first update should be to implement this, but only for unfilled orders. This will fix the issues people are currently having. Reducing the footprint of filled orders and providing a way to backup records are also good ideas, but less urgent IMO.

@JoeGruffins
Copy link
Member

I agree with what @martonp said on the pr, just delete any orders that did not match. Delete all canceled orders and cancel orders. Anything that did not move funds is useless for record keeping right? If we just did that I assume there would not be a problem?

@JoeGruffins
Copy link
Member

related to #2945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants