Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Consider not storing admin pass in plain text. #281

Open
JoeGruffins opened this issue Jun 24, 2021 · 0 comments · May be fixed by #311
Open

config: Consider not storing admin pass in plain text. #281

JoeGruffins opened this issue Jun 24, 2021 · 0 comments · May be fixed by #311

Comments

@JoeGruffins
Copy link
Member

vspd/config.go

Line 66 in e42b1ca

AdminPass string `long:"adminpass" ini-name:"adminpass" description:"Password for accessing admin page."`

Per SEI CERT C Coding Standard it is best practice not to store plain text passwords in memory or on disk. This could be removed from memory, mostly, by storing the sha256 hash of the admin pass, and constant-time comparing the hashes of incoming passwords. For input on startup, the secure terminal could (optionally) be used which works without a gui to input the pass every start-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant