Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump gin-gonic version up to 1.7.2 #288

Closed
dema501 opened this issue Aug 1, 2021 · 2 comments · Fixed by #289 or #308
Closed

Bump gin-gonic version up to 1.7.2 #288

dema501 opened this issue Aug 1, 2021 · 2 comments · Fixed by #289 or #308

Comments

@dema501
Copy link

dema501 commented Aug 1, 2021

Gin recognizes "X-Forwarded-For", "X-Real-IP" headers now

gin-gonic/gin@bfc8ca2#diff-447bee2da23875fead662441fef4b89e1918d4b5f01d1aa3f5d6cdc0cc51a4acR161

I'm seeing in vspd.log a lot of:

2021-08-01 11:39:20.021 [WRN] API: ticketStatus: Unknown ticket (clientIP=172.16.1.1)
...
2021-08-01 11:39:21.622 [WRN] API: ticketStatus: Unknown ticket (clientIP=172.16.1.1)
2021-08-01 11:39:21.740 [WRN] API: ticketStatus: Unknown ticket (clientIP=172.16.1.1)
2021-08-01 11:39:21.999 [WRN] API: ticketStatus: Unknown ticket (clientIP=172.16.1.1)

It's hard to understand who
@dema501 dema501 changed the title Bump gin-tonic to 1.7.2 Bump gin-gonic to 1.7.2 Aug 1, 2021
@dema501 dema501 changed the title Bump gin-gonic to 1.7.2 Bump gin-gonic version to 1.7.2 Aug 1, 2021
@dema501 dema501 changed the title Bump gin-gonic version to 1.7.2 Bump gin-gonic version up to 1.7.2 Aug 1, 2021
@jholdstock jholdstock mentioned this issue Aug 3, 2021
Merged
@jholdstock
Copy link
Member

Already using 1.7.2 on master, and it will be included in the next release. #289 updates to 1.7.3 and will close this issue.

@jholdstock
Copy link
Member

Re-opening this because there is a unreleased bugfix we need before cutting the our next release. Latest word is that the fix should be in gin-gonic 1.7.5

gin-gonic/gin#2904

@jholdstock jholdstock reopened this Oct 29, 2021
@jholdstock jholdstock mentioned this issue Nov 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use latest gin-gonic patch jholdstock/vspd
Update gin to 1.7.7. jholdstock/vspd
2 participants
@dema501 @jholdstock