Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making the default classifier a random forest #990

Open
fgregg opened this issue Apr 25, 2022 · 2 comments · May be fixed by #1031
Open

Consider making the default classifier a random forest #990

fgregg opened this issue Apr 25, 2022 · 2 comments · May be fixed by #1031

Comments

@fgregg
Copy link
Contributor

fgregg commented Apr 25, 2022

I bet it would generally be better at picking up some of the funny relationships.
@fgregg fgregg mentioned this issue Apr 25, 2022
Closed
@NickCrews
Copy link
Contributor

I think this is a very good motivation for #991

@fgregg fgregg mentioned this issue Apr 26, 2022
Merged
3 tasks
@fgregg
Copy link
Contributor Author

fgregg commented Jun 2, 2022

I ended up not switching to random forest in #992 and continue to use regularized logistic regression.

the loss in precision for the canonical case was a bit more than i was fully comfortable with, and wanted more time to think about.

not quite ready to close though.

@fgregg fgregg linked a pull request Jun 2, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch logistic classifier to random forest as default classifier dedupeio/dedupe
2 participants
@fgregg @NickCrews