Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink locking support within deegree #1259

Open
copierrj opened this issue Jan 5, 2022 · 3 comments
Open

Rethink locking support within deegree #1259

copierrj opened this issue Jan 5, 2022 · 3 comments
Labels
contributions welcome asking for contribution (time and money sponsor) dependencies Pull requests that update a dependency (library) funding welcome financial sponsoring wanted (money) TMC discussion to be discussed by technical management committee members

Comments

@copierrj
Copy link
Member

copierrj commented Jan 5, 2022

We are currently using H2 to implement local locking. Given that this is the only thing we use H2 for we should rethink this strategy. We should at least be able to drop the H2 dependency as this would resolve #1250.

The WFS should use the locking functionality provided by the database backing the FeatureStore and when a file based FeatureStore is in use we could consider refusing locking requests.

@tfr42 tfr42 added contributions welcome asking for contribution (time and money sponsor) funding welcome financial sponsoring wanted (money) TMC discussion to be discussed by technical management committee members labels Jan 5, 2022
@tfr42 tfr42 added the dependencies Pull requests that update a dependency (library) label Jan 15, 2022
@tfr42
Copy link
Member

tfr42 commented Feb 16, 2022

The TMC has the notion to remove the dependency to H2 and document that users have to provide a compatible database him/herself.
As an alternative the feature is kept and an upgrade of H2 is required. Contributions are highly appreciated.

@stephanr
Copy link
Member

The following matches in the source tree may also be wrong imports

Other places where h2 is used are:

@stephanr
Copy link
Member

There is also a collision on Tables named "LOCKS", so if that was the only problem, #1296 would fix it, and we could at least upgrade H2 to a safer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome asking for contribution (time and money sponsor) dependencies Pull requests that update a dependency (library) funding welcome financial sponsoring wanted (money) TMC discussion to be discussed by technical management committee members
Projects
None yet
Development

No branches or pull requests

3 participants