Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal filter PropertyIsLessThan is not working with date values #1422

Open
dstenger opened this issue Nov 10, 2022 · 4 comments
Open

Temporal filter PropertyIsLessThan is not working with date values #1422

dstenger opened this issue Nov 10, 2022 · 4 comments
Labels
contributions welcome asking for contribution (time and money sponsor)

Comments

@dstenger
Copy link
Contributor

dstenger commented Nov 10, 2022

When following request is sent:

<wfs:GetFeature xmlns:wfs="http://www.opengis.net/wfs/2.0" count="10" service="WFS"
                version="2.0.0">
   <wfs:Query xmlns:ns79="urn:x-inspire:specification:gmlas:ProtectedSites:3.0"
              typeNames="ns79:ProtectedSite">
      <Filter xmlns="http://www.opengis.net/fes/2.0">
         <PropertyIsLessThan matchAction="All" matchCase="true">
            <Literal>2012-05-13T00:00:00</Literal>
            <ValueReference xmlns:tns="urn:x-inspire:specification:gmlas:ProtectedSites:3.0">tns:legalFoundationDate</ValueReference>
         </PropertyIsLessThan>
      </Filter>
   </wfs:Query>
</wfs:GetFeature>

no features are returned.

However, when sending the same request without filter

<wfs:GetFeature xmlns:wfs="http://www.opengis.net/wfs/2.0" count="20" service="WFS"
                version="2.0.0">
   <wfs:Query xmlns:ns79="urn:x-inspire:specification:gmlas:ProtectedSites:3.0"
              typeNames="ns79:ProtectedSite">
   </wfs:Query>
</wfs:GetFeature>

features are returned which should match the filter:

  • <ps:legalFoundationDate>2012-05-11T00:00:00</ps:legalFoundationDate>

Please also see opengeospatial/ets-wfs20#240.

@dstenger
Copy link
Contributor Author

I did some research in the specs and my conclusion is that PropertyIsLessThan should not work for temporal values.

This topic is also discussed in opengeospatial/ets-wfs20#240. I propose to wait for the conclusion in that issue and to handle this issue accordingly.

@dstenger
Copy link
Contributor Author

Feedback from SWG: opengeospatial/ets-wfs20#224 (comment)

It is pointed out that this case is not 100% clear. However, they do not see a reason why PropertyIsLessThan should not be usable with temporal values.
Thus, this reported issue is still valid and should be reviewed by the TMC.

@JohannaOtt
Copy link

Additionally (and related IMO), a request using a "property is less than" filter with temporal values also returns features which have a nil value in the requested property.
According to this comment, this should not be the case.

@dstenger dstenger added the bug error issue and bug (fix) label Nov 30, 2022
@dstenger dstenger changed the title Temporal filter PropertyIsLessThan is not working Temporal filter PropertyIsLessThan is not working with date values Dec 14, 2022
@dstenger dstenger added contributions welcome asking for contribution (time and money sponsor) and removed bug error issue and bug (fix) labels Dec 14, 2022
@dstenger
Copy link
Contributor Author

@JohannaOtt The deegree TMC decided to move your reported problem into a separate issue which you can find here: #1440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome asking for contribution (time and money sponsor)
Projects
None yet
Development

No branches or pull requests

2 participants