Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some confusing issues in the code #1

Open
zzhang2816 opened this issue Sep 10, 2024 · 0 comments
Open

Some confusing issues in the code #1

zzhang2816 opened this issue Sep 10, 2024 · 0 comments

Comments

@zzhang2816
Copy link

Thanks for the greate work. But there seems exist some problems in the code:

  1. Function name

    def position_replacement(args):

    It seems should be evaluate_position_replacement, so it can be called in the following code

  2. Import module

    from inception import InceptionV3

    No module named "inception". I change it to "from pytorch_fid.inception import InceptionV3"

  3. For evaluating positional addition

    if mean_y_addition < mean_y_original:

    I think here mean_y_addition represents the y axis of the added object and mean_y_original represents the y axis of the select object in the original scene, then when the positional addition is a "below" relation (added object -> below -> select object), the mean_y_addition should be greater than mean_y_original. But here the score is given for the opposite. Same problem for the "top" relation.

@zzhang2816 zzhang2816 changed the title Some confusion issues in the code Some confusing issues in the code Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant