Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotation axis #2

Open
crizCraig opened this issue Feb 10, 2020 · 1 comment
Open

Fix rotation axis #2

crizCraig opened this issue Feb 10, 2020 · 1 comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@crizCraig
Copy link
Member

We currently use the bike model to calculate the center (x,y), and angle of the vehicle using slip angle. However, when we rotate the four points defining the top-down ego rectangle, we use the center as the axis of rotation instead of the center of the rear axle. You can feel how unrealistic the current rotational axis is when playing the sim yourself. The bike model already accounts for the distance between the axles and center of gravity in it's x, y, and angle outputs - I believe the center of the car is modeled correctly according to the bike model - however the extents of the car and collision detection are currently off due to rotating about the center instead of the rear axle.

@crizCraig crizCraig added enhancement New feature or request good first issue Good for newcomers bug Something isn't working help wanted Extra attention is needed labels Feb 10, 2020
@crizCraig
Copy link
Member Author

Being worked in in #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant