Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial version of interactive dataset explorer. Closes #1692 #1694

Merged
merged 68 commits into from
Jul 27, 2020

Conversation

brollb
Copy link
Contributor

@brollb brollb commented May 13, 2020

This still needs:

  • configuration of the compute on load
  • storage of the generated figures (open and edit again?)
  • don't show slice syntax errors until 'change' event (kinda annoying atm)

This depends on #1693

@brollb
Copy link
Contributor Author

brollb commented Jul 15, 2020

I am planning on merging this soon as this PR has gotten rather large due to the number of dependencies/prerequisites to support this. This is currently blocked by #1747 as this visualizer saves the plotly JSON directly in the metadata node.

This PR includes introducing two new concepts:

  • InteractiveEditor. This is a visualizer which will automatically have a shield requiring the user to initialize an interactive compute session for the editor to use. These types of editors may be able to save and suspend. Suspending is not yet fully supported but enables the interactive session to be resumed later. Saving is supported if the widget implements getSnapshot (data to save), getOperation (operation to reproduce), and getEditorState (implicit operation).
  • InteractiveExplorer. An interactive explorer is designed to create metadata about some artifact that is being inspected. The requirements for saving are also less strict; the explorer is allowed to save metadata which does not record provenance information. This is allowed for a couple reasons; one of which is that this enables the creation of explorers which do not have corresponding python operations. One example is the integration of a tool like Facets which is a browser-based tool.

There are also some known issues that are going to be saved for another PR:

  • method for opening the interactive editors/explorers.
  • "save" button disappears after the first save (related to action registration)
  • tensors with custom serializers/deserializers are not deserialized correctly

@brollb brollb marked this pull request as ready for review July 21, 2020 21:09
@brollb brollb merged commit 10f5d13 into master Jul 27, 2020
@brollb brollb deleted the 1692-interactive-dataset-exploration branch July 27, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant