Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove openapi websocket classes #187

Open
2 of 3 tasks
niloc132 opened this issue Mar 23, 2021 · 1 comment
Open
2 of 3 tasks

Remove openapi websocket classes #187

niloc132 opened this issue Mar 23, 2021 · 1 comment
Assignees
Milestone

Comments

@niloc132
Copy link
Member

niloc132 commented Mar 23, 2021

With the rewrite to gRPC, we no longer need web-shared-beans and web-shared-socket, but these classes are still used from a few places. Any code that uses web-shared-socket no longer works, since the websocket itself was removed.

  • c# is built from this, should all be deleted until the API is solidified in enterprise, and the gRPC api is solidified in open source. This doesn't work presently anyway.
  • jupyter probably also makes sense to be deleted since it uses websockets not only for openapi but also for forwarding sockets, and that isn't rebuilt to work in envoy yet either.
  • js api uses the web-shared-beans classes to manage state, and to simplify updating to gRPC many protobuf objects are being copied to the old beans before being exposed to JS.
@niloc132 niloc132 self-assigned this Mar 23, 2021
@mofojed mofojed added this to the April 2021 milestone Apr 29, 2021
@niloc132 niloc132 modified the milestones: April 2021, Backlog May 11, 2021
@niloc132
Copy link
Member Author

See also
#186
#188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants