Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in SelectColumnLayer.prepareSourcesForParallelPopulation #3805

Closed
rcaudy opened this issue May 6, 2023 · 0 comments · Fixed by #3806
Closed

Bug in SelectColumnLayer.prepareSourcesForParallelPopulation #3805

rcaudy opened this issue May 6, 2023 · 0 comments · Fixed by #3806
Assignees
Labels
bug Something isn't working core Core development tasks query engine
Milestone

Comments

@rcaudy
Copy link
Member

rcaudy commented May 6, 2023

A recent fix to prepareForParallelPopulation for the Immutable*ArraySource implementations exposed that we're passing the wrong RowSequence when flattenedResult. We can also be a little more optimal regarding modifies in the common case.

java.lang.UnsupportedOperationException: (No message provided)	
at io.deephaven.engine.table.impl.sources.immutable.Immutable2DByteArraySource.ensureCapacity(Immutable2DByteArraySource.java:123)	
at io.deephaven.engine.table.impl.sources.immutable.Immutable2DByteArraySource.prepareForParallelPopulation(Immutable2DByteArraySource.java:342)	
at io.deephaven.engine.table.impl.select.analyzers.SelectColumnLayer.prepareSourcesForParallelPopulation(SelectColumnLayer.java:561)	
at io.deephaven.engine.table.impl.select.analyzers.SelectColumnLayer.prepareParallelUpdate(SelectColumnLayer.java:219)	
at io.deephaven.engine.table.impl.select.analyzers.SelectColumnLayer$1.lambda$onAllRequiredColumnsCompleted$0(SelectColumnLayer.java:196)	
at io.deephaven.engine.table.impl.util.OperationInitializationPoolJobScheduler.lambda$submit$0(OperationInitializationPoolJobScheduler.java:27)	
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)	
at java.util.concurrent.FutureTask.run(FutureTask.java:264)	
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)	
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)	
at io.deephaven.engine.table.impl.OperationInitializationThreadPool$1.lambda$newThread$0(OperationInitializationThreadPool.java:50)	
at java.lang.Thread.run(Thread.java:833)
@rcaudy rcaudy added bug Something isn't working triage labels May 6, 2023
@rcaudy rcaudy self-assigned this May 6, 2023
@rcaudy rcaudy added query engine core Core development tasks and removed triage labels May 6, 2023
@rcaudy rcaudy added this to the Apr 2023 milestone May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Core development tasks query engine
Projects
None yet
1 participant